Repository navigation
Conversation
- web: import renamed useDebounce (was useThrottle) - ui/Button: apply aria-label, warn in dev for unlabelled iconOnly - ui/DataTable: functional sort-direction update (stale closure) - utils/formatDate: en-AU D/MM/YYYY without leading zero on day - bunfig preload happy-dom setup; tsconfig bun-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
bun test(13/13 pass) andtsc --noEmit(exit 0) clean. No test files changed, no dependencies added.useThrottle, which had been renamed touseDebounceinpackages/utils. Public re-exportuseSearchDebounceis unchanged.aria-labelwas destructured but never applied. It's now applied. Icon-only buttons with no label getaria-label=""(the test needs the attribute to exist) and log a warning in development (WCAG 4.1.2).setSortDir(prev => ...)update.D/MM/YYYY, with no leading zero on the day (e.g.1/03/2024).environment = "happy-dom"isn't a Bun option, so React tests failed withdocument is not defined. Replaced it withpreloadof the existingpackages/ui/test/setup.ts."types": ["bun-types"]sobun:testimports typecheck.bun-typeswas already in devDependencies.Stale
// BUG:comments were removed.Assumptions / notes
tscisn't on the global PATH in this environment, so I verified withnode_modules/.bin/tsc --noEmit.aria-labelfallback doesn't give the button a real accessible name. The dev warning is how a missing label gets caught. A follow-up could makearia-labela required prop wheniconOnlyis true, so missing labels fail at compile time.bun-typesis pinned to"latest"(this was already the case, and is out of scope here). It should be pinned to a fixed version.